Enforce silent downcasting deprecation #57328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandas/core/internals/blocks.py
# Conflicts: # doc/source/whatsnew/v3.0.0.rst
mroeschke
approved these changes
Feb 13, 2024
|
Thanks @phofl |
This was referenced Feb 21, 2024
| @@ -106,6 +106,7 @@ Removal of prior version deprecations/changes | |||
| - :func:`read_excel`, :func:`read_json`, :func:`read_html`, and :func:`read_xml` no longer accept raw string or byte representation of the data. That type of data must be wrapped in a :py:class:`StringIO` or :py:class:`BytesIO` (:issue:`53767`) | |||
| - All arguments except the first ``path``-like argument in IO writers are now keyword only (:issue:`54229`) | |||
| - Changed the default value of ``observed`` in :meth:`DataFrame.groupby` and :meth:`Series.groupby` to ``True`` (:issue:`51811`) | |||
| - Enforced silent-downcasting deprecation for :ref:`all relevant methods <whatsnew_220.silent_downcasting>` (:issue:`54710`) | |||
There was a problem hiding this comment.
looks like the option still exists in config_init and it is set in 3 tests
There was a problem hiding this comment.
The option will need to be deprecated in a follow up, but it can be removed in those tests
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Enforce silent downcasting deprecation * Update * Update * Add whatsnew * Fixup docstrings * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.