CLN remove dataframe api consortium entrypoint #57482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
remove dataframe api consortium entrypoint
|
Just curious why you didn't update the @rgommers are you aware of this change? |
|
Hey Anatoly, I can't remember exactly, I probably just forgot |
I don't think I was, thanks for pointing it out. This change was breaking it looks like (or you wouldn't have noticed in Modin I think), and the maintenance burden was minimal (xref gh-54383 comments), so I wouldn't have done it this way. But ultimately decisions like this are up to the maintainers alone, so it is what it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed privately
In short:
The Consortium is more than welcome to work on this, but outside of pandas