BUG: Subtraction fails with matching index of different name and type (pandas-dev#57524)

doc/source/whatsnew/v3.0.0.rst

@@ -268,6 +268,7 @@ Bug fixes
 - Fixed bug in :meth:`DataFrame.to_string` that raised ``StopIteration`` with nested DataFrames. (:issue:`16098`)
 - Fixed bug in :meth:`DataFrame.update` bool dtype being converted to object (:issue:`55509`)
 - Fixed bug in :meth:`Series.diff` allowing non-integer values for the ``periods`` argument. (:issue:`56607`)
+- Fixed bug in :meth:`take` allowing ``indexer`` argument to be None (:issue:`57524`)
 
 Categorical
 ^^^^^^^^^^^

pandas/core/algorithms.py

@@ -1186,7 +1186,10 @@ def take(
     if not is_array_like(arr):
         arr = np.asarray(arr)
 
-    indices = ensure_platform_int(indices)
+    if indices is None:
+        indices = np.arange(arr.shape[axis], dtype=np.intp)
+    else:
+        indices = ensure_platform_int(indices)
 
     if allow_fill:
         # Pandas style, -1 means NA

pandas/tests/series/test_arithmetic.py

@@ -368,6 +368,94 @@ def test_add_list_to_masked_array_boolean(self, request):
             result = [True, None, True] + ser
         tm.assert_series_equal(result, expected)
 
+    def test_arithmetic_same_index_same_dtype(self):
+        s1 = Series(
+            [23, 22, 21],
+            index=Index(["a", "b", "c"], name="index a", dtype=pd.StringDtype()),
+            dtype=pd.Int64Dtype(),
+        )
+
+        s2 = Series(
+            [21, 22, 23],
+            index=Index(["a", "b", "c"], name="index a", dtype=pd.StringDtype()),
+            dtype=pd.Int64Dtype(),
+        )
+        expected_result = Series(
+            [2, 0, -2],
+            index=Index(["a", "b", "c"], name="index a", dtype=pd.StringDtype()),
+            dtype=pd.Int64Dtype(),
+        )
+
+        result = s1 - s2
+
+        tm.assert_series_equal(result, expected_result)
+
+    def test_arithmetic_different_index_same_dtype(self):
+        s1 = Series(
+            [23, 22, 21],
+            index=Index(["a", "b", "c"], name="index a", dtype=pd.StringDtype()),
+            dtype=pd.Int64Dtype(),
+        )
+
+        s2 = Series(
+            [21, 22, 23],
+            index=Index(["a", "b", "c"], name="index b", dtype=pd.StringDtype()),
+            dtype=pd.Int64Dtype(),
+        )
+        expected_result = Series(
+            [2, 0, -2],
+            index=Index(["a", "b", "c"], name="index a", dtype=pd.StringDtype()),
+            dtype=pd.Int64Dtype(),
+        )
+
+        result = s1 - s2
+
+        tm.assert_series_equal(result, expected_result)
+
+    def test_arithmetic_same_index_different_dtype(self):
+        s1 = Series(
+            [23, 22, 21],
+            index=Index(["a", "b", "c"], name="index a", dtype=pd.StringDtype()),
+            dtype=pd.Int64Dtype(),
+        )
+
+        s2 = Series(
+            [21, 22, 23],
+            index=Index(["a", "b", "c"], name="index a"),
+            dtype=pd.Int64Dtype(),
+        )
+        expected_result = Series(
+            [2, 0, -2],
+            index=Index(["a", "b", "c"], name="index a", dtype=pd.StringDtype()),
+            dtype=pd.Int64Dtype(),
+        )
+
+        result = s1 - s2
+
+        tm.assert_series_equal(result, expected_result)
+
+    def test_arithmetic_different_index_different_dtype(self):
+        s1 = Series(
+            [23, 22, 21],
+            index=Index(["a", "b", "c"], name="index a", dtype=pd.StringDtype()),
+            dtype=pd.Int64Dtype(),
+        )
+
+        s2 = Series(
+            [21, 22, 23],
+            index=Index(["a", "b", "c"], name="index b"),
+            dtype=pd.Int64Dtype(),
+        )
+        expected_result = Series(
+            [2, 0, -2],
+            index=Index(["a", "b", "c"], name="index a", dtype=pd.StringDtype()),
+            dtype=pd.Int64Dtype(),
+        )
+
+        result = s1 - s2
+
+        tm.assert_series_equal(result, expected_result)
+
 
 # ------------------------------------------------------------------
 # Comparisons

pandas/tests/test_take.py

@@ -250,6 +250,12 @@ def test_take_non_hashable_fill_value(self):
         expected = np.array([2, [1]], dtype=object)
         tm.assert_numpy_array_equal(result, expected)
 
+    def test_take_indices_is_None(self):
+        arr = np.array([1, 2, 3])
+        indexer = None
+        result = algos.take(arr, indexer)
+        tm.assert_numpy_array_equal(result, arr)
+
 
 class TestExtensionTake:
     # The take method found in pd.api.extensions