Skip to content

Nanosecond fixed precision of DatetimeIndex with time zone information, Fix #53473 #57703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MarcusJak
Copy link

The expected behaviour is now correct from issue #53473 The out->picoseond value wasn't set which ended with a Json error regarding the ns calculations.

Fix pandas-dev#53473

The expected behaviour is now correct from issue pandas-dev#53473
The out->picoseond value wasn't set which ended with a Json error regarding the ns calculations.
@MarcusJak MarcusJak requested a review from WillAyd as a code owner March 2, 2024 16:45
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you also add a test for this in pandas/tests/io/json/test_pandas.py?

@MarcusJak MarcusJak requested a review from WillAyd March 4, 2024 14:01
@robinho46
Copy link

Hi @WillAyd could you please check the new fixes, we would appreciate that :)

@mroeschke mroeschke added the IO JSON read_json, to_json, json_normalize label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Apr 7, 2024

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Apr 7, 2024
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO JSON read_json, to_json, json_normalize Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_json does not preserve nanosecond precision of DatetimeIndex with time zone information
5 participants