-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: pretty print all Mappings, not just dicts #57915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be OK. Could you come up with a test?
3e9d00b
to
c5e8968
Compare
that was a pretty nice experience setting up a dev environment locally, pass along my compliments to the rest of the pandas maintainers @mroeschke ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a whatsnew note in v3.0.0.rst
?
This was discovered in ibis-project/ibis#8693
c5e8968
to
777740f
Compare
Thanks @NickCrews |
This was discovered in ibis-project/ibis#8693
This was discovered in ibis-project/ibis#8687
Due to a strict
isinstance(x, dict)
check, custom mapping types would instead get treated as mere iterables, so only the keys would get printed as a tuple:doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.