CLN: move raising TypeError for interpolate with object dtype to Block
#58083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/internals/blocks.py
Outdated
| if self.dtype == _dtype_obj: | ||
| # only deal with floats | ||
| # bc we already checked that can_hold_na, we don't have int dtype here | ||
| # test_interp_basic checks that we make a copy here | ||
| return [self.copy(deep=False)] | ||
| raise TypeError( | ||
| f"{type(self).__name__} cannot interpolate with object dtype." |
There was a problem hiding this comment.
we dont need to have Block in the exception message. the comments in the line above can be removed. can you add "# GH#53631"
There was a problem hiding this comment.
can do something like name = {1: "Series", 2: "DataFrame"}[self.ndim] to keep the exception message unchanged
There was a problem hiding this comment.
thank you, I made these changes, ci - green.
natmokval
added
Clean
Missing-data
|
thanks @natmokval |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…Block (pandas-dev#58083) * move raising for interpolate with object dtype from NDFrame to Block * correct msg in test_interpolate_cannot_with_object_dtype * correct the exception message and the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #57820
moved raising
TypeErrorforinterpolatewith object dtype fromNDFrametoBlock