CLN: union_indexes #58183
Merged
CLN: union_indexes #58183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Apr 8, 2024
mroeschke
commented
- Just used sets where appropriate
- Added some typing
- Split some helper functions to branches where they are used
WillAyd
approved these changes
Apr 9, 2024
jbrockmendel
reviewed
Apr 9, 2024
|
|
||
| if list in kinds: | ||
| if len(kinds) > 1: | ||
| indexes = [ | ||
| Index(list(x)) if not isinstance(x, Index) else x for x in indexes | ||
| ] | ||
| kinds.remove(list) | ||
| kinds -= {list} |
There was a problem hiding this comment.
id expect this to be slightly slower?
There was a problem hiding this comment.
In [2]: kinds = {pd.DatetimeIndex, pd.Index, list}
In [3]: %time kinds -= {list}
CPU times: user 3 µs, sys: 0 ns, total: 3 µs
Wall time: 4.29 µs
In [4]: kinds = list({pd.DatetimeIndex, pd.Index, list})
In [5]: %time kinds.remove(list)
CPU times: user 5 µs, sys: 1e+03 ns, total: 6 µs
Wall time: 8.82 µs
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Clean up logic in union_indexes * add typing * Just use the generator version * Undo typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.