-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
GH: PDEP vote issue template #58204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
GH: PDEP vote issue template #58204
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
68cb1bc
Create pdep_vote.yaml
Aloqeely 0166891
Merge pull request #1 from Aloqeely/test-issue-template
Aloqeely a1ef8e8
Unindent validations
Aloqeely b521c34
PDEP voting issue template
Aloqeely f93c9ab
Update pdeps path
Aloqeely 11524b5
Minor changes
Aloqeely f4091ae
Update label name
Aloqeely bf6db16
Better wording
Aloqeely d421d27
Remove placeholder
Aloqeely f7384f0
ignore::
Aloqeely 547ba8c
Remove wrong files
Aloqeely File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
name: PDEP Vote | ||
description: Call for a vote on a PDEP | ||
title: "VOTE: " | ||
labels: [Vote] | ||
|
||
body: | ||
- type: markdown | ||
attributes: | ||
value: > | ||
As per [PDEP-1](https://pandas.pydata.org/pdeps/0001-purpose-and-guidelines.html), the following issue template should be used when a | ||
maintainer has opened a PDEP discussion and is ready to call for a vote. | ||
- type: checkboxes | ||
attributes: | ||
label: Locked issue | ||
options: | ||
- label: > | ||
I locked this voting issue so that only voting members are able to cast their votes or | ||
comment on this issue. | ||
required: true | ||
- type: input | ||
id: PDEP-name | ||
attributes: | ||
label: PDEP number and title | ||
placeholder: > | ||
PDEP-1: Purpose and guidelines | ||
validations: | ||
required: true | ||
- type: input | ||
id: PDEP-link | ||
attributes: | ||
label: Pull request with discussion | ||
description: e.g. https://github.com/pandas-dev/pandas/pull/47444 | ||
validations: | ||
required: true | ||
- type: input | ||
id: PDEP-rendered-link | ||
attributes: | ||
label: Rendered PDEP for easy reading | ||
description: e.g. https://github.com/pandas-dev/pandas/pull/47444/files?short_path=7c449e6#diff-7c449e698132205b235c501f7e47ebba38da4d2b7f9492c98f16745dba787041 | ||
validations: | ||
required: true | ||
- type: input | ||
id: PDEP-number-of-discussion-participants | ||
attributes: | ||
label: Discussion participants | ||
description: > | ||
You may find it useful to list or total the number of participating members in the | ||
PDEP discussion PR. This would be the maximum possible disapprove votes. | ||
placeholder: > | ||
14 voting members participated in the PR discussion thus far. | ||
- type: input | ||
id: PDEP-vote-end | ||
attributes: | ||
label: Voting will close in 15 days. | ||
description: The voting period end date. ('Voting will close in 15 days.' will be automatically written) | ||
placeholder: > | ||
On January 15. | ||
- type: markdown | ||
attributes: | ||
value: --- | ||
- type: textarea | ||
id: Vote | ||
attributes: | ||
label: Vote | ||
value: | | ||
Cast your vote in a comment below. | ||
* +1: approve. | ||
* 0: abstain. | ||
* Reason: A one sentence reason is required. | ||
* -1: disapprove | ||
* Reason: A one sentence reason is required. | ||
A disapprove vote requires prior participation in the linked discussion PR. | ||
|
||
@pandas-dev/pandas-core | ||
validations: | ||
required: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.