DOC: use Hashable instead of label #61500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
approved these changes
May 27, 2025
There was a problem hiding this comment.
lgtm, I'll let @mroeschke have a look, since he was the one who suggested this.
| Column or index level names to join on. These must be found in both | ||
| DataFrames. If `on` is None and not merging on indexes then this defaults | ||
| to the intersection of the columns in both DataFrames. | ||
| left_on : label or list, or array-like | ||
| left_on : Hashable or a sequence of the previous, or array-like |
There was a problem hiding this comment.
Not sure if a sequence of the previous already means array-like. No big deal, but I guess it could be removed.
There was a problem hiding this comment.
My experience was that numpy.typing.NDArray is somehow not a collections.abc.Sequence, and numpy.typing.ArrayLike is even more complicated than an NDArray. That was why I left them as separate things.
mroeschke
approved these changes
May 27, 2025
|
Thanks @cmp0xff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #61455 (comment):
[ ] closes #xxxx (Replace xxxx with the GitHub issue number)[ ] Tests added and passed if fixing a bug or adding a new feature[ ] Added type annotations to new arguments/methods/functions.[ ] Added an entry in the latestdoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.