Skip to content

BUG: interpolate should preserve dtypes #6378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2014

Conversation

TomAugspurger
Copy link
Contributor

Closes #6290

Replaces PR #6291 due to github / git issues.

@jreback I think opening a new PR will be easier. I'm was having trouble getting that branch and the PR in #6291 to sync up.

I noticed that you got the missing comma in the join_merge vbench added so I've removed that commit.

jreback added a commit that referenced this pull request Feb 17, 2014
@jreback jreback merged commit 0f73f5f into pandas-dev:master Feb 17, 2014
@jreback
Copy link
Contributor

jreback commented Feb 17, 2014

pefect thanks!

@jreback
Copy link
Contributor

jreback commented Feb 17, 2014

minor FYI, always use fully dtypes for comparions...int will fail on a 32-bit platform....

As pandas will ALWAYS coerce any input data to int64/float64 (except if its specifically dtyped);
the problem is that on a 32-bit platform is that numpy defaults to int so even something as simple as
np.arange(5) will become int32 on a 32-bit platform

173c686

@TomAugspurger TomAugspurger deleted the interpolate-ignore-good3 branch November 3, 2016 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Interpolate should be more careful with dtypes
2 participants