Skip to content

BUG: MPLPlot cannot make loglog keyword worked #6722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2014

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Mar 27, 2014

Changes made in #5638 make loglog keyword not worked, and it fixes the problem.

@TomAugspurger TomAugspurger self-assigned this Mar 28, 2014
@jreback jreback added this to the 0.14.0 milestone Mar 28, 2014
@jtratner
Copy link
Contributor

looks good to me - thanks for submitting this! Doesn't need a doc note b/c both are within 0.14

@jtratner
Copy link
Contributor

@sinhrks could you add a note to the docstrings that marks the existence of loglog? e.g. around line 1881 in pandas/tool/plotting.py after the comment descibing logy. That would help other users actually know about this.

@sinhrks
Copy link
Member Author

sinhrks commented Mar 30, 2014

Thank you for your confirmation. Docstring added, and I removed descriptions specifying line plot because now log-related keyword can be used in all plots thanks to #5638.

jreback added a commit that referenced this pull request Mar 30, 2014
BUG: MPLPlot cannot make loglog keyword worked
@jreback jreback merged commit 540c1ab into pandas-dev:master Mar 30, 2014
@jreback
Copy link
Contributor

jreback commented Mar 30, 2014

@sinhrks thanks!

@sinhrks sinhrks deleted the loglog branch March 31, 2014 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants