-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Custom Business Month #6866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Business Month #6866
Conversation
did u rebuild extensions? this was just added in cython python setup.py build_ext --inplace |
Ok that was part of it. Apparently Travis is on numpy 1.6 so the CBMonth (requires numpy 1.7) tests are failing. |
their are multiple versions of numpy tested with Travis |
Ah good hint, found the problem, will send an update later tonight. |
I added |
pls rebase (u need to incorporate #6873 the apply_nat) |
How should I reference the enhancement in |
yep (when no associated issue the pr number works too) |
Rebased, added a small section to the docs. Anything else? |
can u do the Apply_nat decorator like other apply? it's just more consistent that way @jorisvandenbossche @TomAugspurger comments? |
@bjonen can you rebase? |
done |
thank you sir! |
FYI, had to do this little patch a189d5d was failing on windows 2.6 for some reason (and not sure why didn't fail on linux) |
Ok, thanks! |
This extends the
offsets.py
module with aCBMonthEnd
based onCustomBusinessDay
. Tests are found intest_offsets.py
.A few small points still open:
DateOffset.onOffset
.Also some of the tests are not passing, but the errors seem unrelated.
e.g.