BUG: Fixed failure in StataReader when reading variable labels in 117 #7818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anyway to include a test file? (small one) |
|
I haven't added a test yet, but will do. |
|
@jreback Test added, so if no typos and all pass, should be ready |
| @@ -551,6 +554,18 @@ def test_bool_uint(self): | |||
| written_and_read_again = written_and_read_again.set_index('index') | |||
| tm.assert_frame_equal(written_and_read_again, expected) | |||
|
|
|||
| def test_variable_labels(self): | |||
| sr_115 = StataReader(self.dta16_115).variable_labels() | |||
| sr_117 = StataReader(self.dta16_115).variable_labels() | |||
There was a problem hiding this comment.
should this not be the other file?
|
I think it is ready now. |
|
ok, ping when green |
|
Strange, a failure in a file I didn't change. |
|
I think that was fixed |
… files Stata's implementation does not match the online dta file format description. The solution used here is to directly compute the offset rather than reading it from the dta file. If Stata fixes their implementation, the original code can be restored. closes pandas-dev#7816
|
Rebased |
|
these look like small test files you created, yes? (which is good) |
jreback
added a commit
that referenced
this pull request
Jul 23, 2014
BUG: Fixed failure in StataReader when reading variable labels in 117
|
@bashtage thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stata's implementation does not match the online dta file format description.
The solution used here is to directly compute the offset rather than reading
it from the dta file. If Stata fixes their implementation, the original code
can be restored.
closes #7816