BUG: Fix groupby methods to include *args and **kwds if applicable. #8758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -282,5 +282,9 @@ def make_signature(func) : | |||
| args = [] | |||
| for i, (var, default) in enumerate(zip(spec.args, defaults)) : | |||
| args.append(var if default=='' else var+'='+repr(default)) | |||
| if spec.varargs: | |||
There was a problem hiding this comment.
their is a test section for these, can you see if you can add a couple of non-plotting tests (e.g. one that has args, the other kwargs)
namely ones that go thru this machinery
|
pls add a release note v0.15.2 as well |
davidastephens
force-pushed
the
issue8733
branch
from
3fbb176 to
0ab77c7
Compare
davidastephens
force-pushed
the
issue8733
branch
from
0ab77c7 to
d6d5542
Compare
|
Added a release note and tests for all the methods that use **kwargs. I couldn't find any that use *args for testing. |
jreback
added a commit
that referenced
this pull request
Nov 8, 2014
BUG: Fix groupby methods to include *args and **kwds if applicable.
|
perfect thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8733 (and any other bug that would result from trying to send an arbitrary keyword to a groupby method).