Skip to content

BUG: Fix groupby methods to include *args and **kwds if applicable. #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2014

Conversation

davidastephens
Copy link
Contributor

Fixes #8733 (and any other bug that would result from trying to send an arbitrary keyword to a groupby method).

@@ -282,5 +282,9 @@ def make_signature(func) :
args = []
for i, (var, default) in enumerate(zip(spec.args, defaults)) :
args.append(var if default=='' else var+'='+repr(default))
if spec.varargs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

their is a test section for these, can you see if you can add a couple of non-plotting tests (e.g. one that has args, the other kwargs)

namely ones that go thru this machinery

@jreback
Copy link
Contributor

jreback commented Nov 8, 2014

pls add a release note v0.15.2 as well

@davidastephens
Copy link
Contributor Author

Added a release note and tests for all the methods that use **kwargs. I couldn't find any that use *args for testing.

jreback added a commit that referenced this pull request Nov 8, 2014
BUG: Fix groupby methods to include *args and **kwds if applicable.
@jreback jreback merged commit 94c91af into pandas-dev:master Nov 8, 2014
@jreback
Copy link
Contributor

jreback commented Nov 8, 2014

perfect thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandas.core.groupby.SeriesGroupBy.hist doesn't take kwargs
2 participants