-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Make Timestamp('now') equivalent to Timestamp.now() #9022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -173,9 +173,9 @@ def ints_to_pytimedelta(ndarray[int64_t] arr, box=False): | |
result[i] = NaT | ||
else: | ||
if box: | ||
result[i] = Timedelta(value) | ||
result[i] = Timedelta(value) | ||
else: | ||
result[i] = timedelta(microseconds=int(value)/1000) | ||
result[i] = timedelta(microseconds=int(value)/1000) | ||
|
||
return result | ||
|
||
|
@@ -216,15 +216,32 @@ class Timestamp(_Timestamp): | |
|
||
@classmethod | ||
def now(cls, tz=None): | ||
""" compat now with datetime """ | ||
""" | ||
Return the current time in the local timezone. Equivalent | ||
to datetime.now([tz]) | ||
|
||
Parameters | ||
---------- | ||
tz : string / timezone object, default None | ||
Timezone to localize to | ||
""" | ||
if isinstance(tz, basestring): | ||
tz = maybe_get_tz(tz) | ||
return cls(datetime.now(tz)) | ||
|
||
@classmethod | ||
def today(cls): | ||
""" compat today with datetime """ | ||
return cls(datetime.today()) | ||
def today(cls, tz=None): | ||
""" | ||
Return the current time in the local timezone. This differs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This docstring needs an update now (and should probably be the same as the one for |
||
from datetime.today() in that it can be localized to a | ||
passed timezone. | ||
|
||
Parameters | ||
---------- | ||
tz : string / timezone object, default None | ||
Timezone to localize to | ||
""" | ||
return cls.now(tz) | ||
|
||
@classmethod | ||
def utcnow(cls): | ||
|
@@ -1021,6 +1038,14 @@ cdef convert_to_tsobject(object ts, object tz, object unit): | |
if util.is_string_object(ts): | ||
if ts in _nat_strings: | ||
ts = NaT | ||
elif ts == 'now': | ||
# Issue 9000, we short-circuit rather than going | ||
# into np_datetime_strings which returns utc | ||
ts = Timestamp.now(tz) | ||
elif ts == 'today': | ||
# Issue 9000, we short-circuit rather than going | ||
# into np_datetime_strings which returns a normalized datetime | ||
ts = Timestamp.today(tz) | ||
else: | ||
try: | ||
_string_to_dts(ts, &obj.dts, &out_local, &out_tzoffset) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test with a tz (just for consistency)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
today() doesn't take a tz argument so I left that particular test out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, if one is passed what should happen? raise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well now that I think about it I see no reason why a tz shouldn't be an allowed argument. Maybe just have today() call now() and then we are done.