Skip to content

feat: Add support for push notifications via ParsePush, ParseNotification #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 22, 2023
Merged

feat: Add support for push notifications via ParsePush, ParseNotification #914

merged 13 commits into from
May 22, 2023

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented May 21, 2023

Pull Request

Issue

Closes: #913 and #742

Approach

This feature is implemented based on the logic of Parse Android

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@mbfakourii mbfakourii requested a review from a team May 21, 2023 15:49
@mtrezza mtrezza changed the title feat: Added ParsePush and ParseNotification feat: Add ParsePush and ParseNotification May 21, 2023
@mtrezza
Copy link
Member

mtrezza commented May 21, 2023

Is this actually a new feature or a bug fix for an existing feature? Was there no push notification support at all so far?

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.47 ⚠️

Comparison is base (f8942ac) 39.04% compared to head (617903a) 38.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   39.04%   38.58%   -0.47%     
==========================================
  Files          57       59       +2     
  Lines        3286     3328      +42     
==========================================
+ Hits         1283     1284       +1     
- Misses       2003     2044      +41     
Impacted Files Coverage Δ
packages/flutter/lib/parse_server_sdk_flutter.dart 8.62% <ø> (ø)
...utter/lib/src/notification/parse_notification.dart 0.00% <0.00%> (ø)
packages/flutter/lib/src/push/parse_push.dart 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mbfakourii
Copy link
Member Author

Is this actually a new feature or a bug fix for an existing feature? Was there no push notification support at all so far?

Such a feature did not exist before and is a new feature

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry and version bump; is this then ready for merge?

@mbfakourii
Copy link
Member Author

Please add changelog entry and version bump; is this then ready for merge?

I tested it several times and it worked fine.
@Nidal-Bakir
What is your opinion? Is it ready for merge?

@mbfakourii
Copy link
Member Author

Please add changelog entry and version bump; is this then ready for merge?

added

@mtrezza mtrezza changed the title feat: Add ParsePush and ParseNotification feat: Add support for push notifications via ParsePush, ParseNotification May 22, 2023
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mbfakourii
Copy link
Member Author

mbfakourii commented May 22, 2023

It seems that we have an error in CI and the codecov section

[2023-05-22T15:54:03.805Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

@mtrezza You may run ci again

@mtrezza
Copy link
Member

mtrezza commented May 22, 2023

Yes, these codedov timeouts occur sometimes, it's an API limit, no issue on our side.

@mtrezza mtrezza closed this May 22, 2023
@mtrezza mtrezza reopened this May 22, 2023
@mtrezza mtrezza merged commit a836d8e into parse-community:master May 22, 2023
@mbfakourii mbfakourii deleted the add_parse_notification branch May 23, 2023 11:40
@cool2apps
Copy link

Is there any documentation how to use ParsePush and ParseNotification?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push Notification
4 participants