-
-
Notifications
You must be signed in to change notification settings - Fork 208
feat: Add support for push notifications via ParsePush
, ParseNotification
#914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for push notifications via ParsePush
, ParseNotification
#914
Conversation
Thanks for opening this pull request! |
ParsePush
and ParseNotification
ParsePush
and ParseNotification
Is this actually a new feature or a bug fix for an existing feature? Was there no push notification support at all so far? |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #914 +/- ##
==========================================
- Coverage 39.04% 38.58% -0.47%
==========================================
Files 57 59 +2
Lines 3286 3328 +42
==========================================
+ Hits 1283 1284 +1
- Misses 2003 2044 +41
☔ View full report in Codecov by Sentry. |
Such a feature did not exist before and is a new feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add changelog entry and version bump; is this then ready for merge?
I tested it several times and it worked fine. |
added |
ParsePush
and ParseNotification
ParsePush
, ParseNotification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It seems that we have an error in CI and the codecov section
@mtrezza You may run ci again |
Yes, these codedov timeouts occur sometimes, it's an API limit, no issue on our side. |
Is there any documentation how to use ParsePush and ParseNotification? |
Pull Request
Issue
Closes: #913 and #742
Approach
This feature is implemented based on the logic of Parse Android
Tasks