Skip to content

refactor: Improve pubspecs files and example projects #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Aug 8, 2023
Merged

refactor: Improve pubspecs files and example projects #956

merged 22 commits into from
Aug 8, 2023

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Jul 30, 2023 •
edited
Loading

Pull Request

Issue

Closes: #957

Approach

Improved pubspecs files base dart site and example projects

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 30, 2023 •
edited
Loading

Thanks for opening this pull request!

@mbfakourii mbfakourii changed the title refactor: Improve pubspecs and examples refactor: Improve pubspecs files and example projects Jul 30, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (a2fb099) 39.60% compared to head (1a68ec4) 39.60%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   39.60%   39.60%           
=======================================
  Files          60       60           
  Lines        3333     3333           
=======================================
  Hits         1320     1320           
  Misses       2013     2013

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbfakourii
improve
42fef65 
improve pubspecs and examples projects
@mbfakourii
fix failed ci
68b710d 
downgrade mockito
@mbfakourii
fix failed ci
31a3b68 
downgrade flutter_lints
@mbfakourii
fix failed ci
cad20b7 
downgrade path
@mbfakourii
fix failed ci
2ac0818 
downgrade sembast
@mbfakourii mbfakourii requested a review from a team July 30, 2023 15:29
mtrezza
mtrezza previously approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is this ready for merge?

@mbfakourii
Copy link
Member Author

mbfakourii commented Aug 2, 2023 •
edited
Loading

Looks good! Is this ready for merge?

Yes, it's ready

@mbfakourii
Copy link
Member Author

mbfakourii commented Aug 2, 2023 •
edited
Loading

this fail tests for this bug
I don't think there is a problem with merge

@mtrezza
Copy link
Member

mtrezza commented Aug 5, 2023

If we restart the CI it should work, since dio has fixed the issue and there's no lock file.

@mtrezza mtrezza mentioned this pull request Aug 5, 2023
Closed
2 tasks
@mbfakourii
Copy link
Member Author

If we restart the CI it should work, since dio has fixed the issue and there's no lock file.

What is your suggestion to improve CI?

@mtrezza
Copy link
Member

mtrezza commented Aug 6, 2023 •
edited
Loading

Improve the CI? What do you mean?

@mbfakourii
Copy link
Member Author

Improve the CI? What do you mean?

I meant here

@mtrezza
Copy link
Member

mtrezza commented Aug 6, 2023 •
edited
Loading

I don't think there's anything to improve. In that comment I was referring to your comment where you said that the CI in this PR here fails because of the dio issue. Since the CI now passes without us changing the dio dependency version, we know that the issue self-resolved and that we can close #959 without us having to publish a release.

@mtrezza mtrezza closed this Aug 6, 2023
@mtrezza mtrezza reopened this Aug 6, 2023
@mbfakourii
Copy link
Member Author

I don't think there's anything to improve. In that comment I was referring to your comment where you said that the CI in this PR here fails because of the dio issue. Since the CI now passes without us changing the dio dependency version, we know that the issue self-resolved and that we can close #959 without us having to publish a release.

So there is no problem.
Regarding this pull request, you may check these two sections. [1] , [2]

mtrezza
mtrezza reviewed Aug 7, 2023
View reviewed changes
mtrezza
mtrezza reviewed Aug 7, 2023
View reviewed changes
mtrezza
mtrezza previously approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is this ready to merge?

mtrezza
mtrezza previously approved these changes Aug 7, 2023
View reviewed changes
@mbfakourii
Copy link
Member Author

Looks good! Is this ready to merge?

Tag each package with at most 5 topics

mtrezza
mtrezza reviewed Aug 7, 2023
View reviewed changes
mtrezza
mtrezza reviewed Aug 7, 2023
View reviewed changes
mtrezza
mtrezza approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about now?

@mbfakourii
Copy link
Member Author

How about now?

It looks good

@mtrezza mtrezza merged commit dc7e3d6 into parse-community:master Aug 8, 2023
@mbfakourii mbfakourii deleted the improve_pubspecs_and_examples branch August 8, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve pubspecs files and example projects
2 participants
@mbfakourii @mtrezza