feat: Add installationId in LiveQuery connect

[mbfakourii]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

Closes: #975

Approach

add installationId in LiveQuery connect.

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, code comments)

[parse-github-assistant]

I will reformat the title to use the proper commit message syntax.

[parse-github-assistant]

Thanks for opening this pull request!

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f757dad) 40.60% compared to head (f2d35bd) 44.12%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
+ Coverage   40.60%   44.12%   +3.51%     
==========================================
  Files          60       60              
  Lines        3401     3404       +3     
==========================================
+ Hits         1381     1502     +121     
+ Misses       2020     1902     -118     

Files	Coverage Δ
...ackages/dart/lib/src/network/parse_live_query.dart	50.90% <71.42%> (+50.90%)	⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mtrezza]

Could you add a test?

[mbfakourii]

Could you add a test?

These additional items are in a private function, it is also for socket operation and cannot be tested.

[mtrezza]

Not sure I understand; why do you think it cannot be tested?

[mbfakourii]

Not sure I understand; why do you think it cannot be tested?

Changes in this function. This function is a private function. It cannot be accessed from outside.

[mtrezza]

Is it not possible to access a private function in tests? How are all the LiveQuery features then tested?

[mbfakourii]

If it not possible to access a private function in tests? How are all the LiveQuery features then tested?

There are currently no tests for LiveQuery!

[mtrezza]

Interesting. It should be easily possible to test an internal method. Can't you just reference the internal method directly in the test file, mock channel, execute the method and check whether the connect message has the installationId set?

[mbfakourii]

Interesting. It should be easily possible to test an internal method. Can't you just reference the internal method directly in the test file, mock channel, execute the method and check whether the connect message has the installationId set?

I did not test with mockito, I will try to implement

[mbfakourii]

@mtrezza

Test added

[mtrezza]

Congrats for adding the first live query test!

[mtrezza]

Looks good! Waiting for CI to pass...

[maravilhosinga]

This should be optional since, it breaks live query when using lower versions of parse server.
Specially for who uses sashido.io

[mtrezza]

@maravilhosinga could you please open a new issue and provide more specifics about what's breaking?