Allow field name with underscore prefix in `Parse.Object.set`

[mtrezza]

New Feature / Enhancement Checklist

• I am not disclosing a vulnerability.
• I am not just asking a question.
• I have searched through existing issues.

Current Limitation

Currently, an error is thrown when setting a field name with underscore prefix in Parse.Object.set. Historically that made sense as these are Parse Server-internal fields. However, with the introduction of access scopes, internal fields can be read from and written to.

Feature / Enhancement Description

The Parse JS SDK should allow sending internal fields to Parse Server, which will then handle the request accordingly. This may not only be relevant for Parse.Object.set but also for Parse.Query conditions on internal fields.

Example Use Case

const obj = new Parse.Object('Test');
obj.set('_internalField', value);

Alternatives / Workarounds

Make a REST API request to avoid the Parse JS SDK restriction.

[parse-github-assistant]

Thanks for opening this issue!

• 🎉 We are excited about your ideas for improvement!

[dplewis]

I think we should remove the field name check from the SDK. Other SDK's like PHP and iOS don't have this check. They let the server handle it. Using the REST API would make this check useless. Also there isn't a check for class names the server handles that too.

I believe this check was in place because the SDK didn't support dot notation at the time. If dot notation was allowed and not supported the SDK internals would be messed up.

Dot notation is now fully supported. You can view the conversation here on why this check was needed.

[dplewis]

Shouldn't this regex allow for underscore already? Looks like the server doesn't support it either. In the case of fields like _context the RESTController overrides it before it gets to the server.

Parse-SDK-JS/src/ParseObject.ts

Lines 1101 to 1103 in 1ad52b1

	for (const key in attrs) {
	if (!/^[A-Za-z][0-9A-Za-z_.]*$/.test(key)) {
	return new ParseError(ParseError.INVALID_KEY_NAME, `Invalid key name: "${key}"`);

[dplewis]

@mtrezza nvm it doesn't allow underscore at the start

[mtrezza]

Yes, the regex requires a letter at the start.

[parseplatformorg]

🎉 This change has been released in version 6.1.0-alpha.1

[parseplatformorg]

🎉 This change has been released in version 6.1.0