Support query.cancel() on Node #1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves abort event to prevent xhr.open from calling it. Ensure requestTask is set after the request sends.
Codecov Report
@@ Coverage Diff @@
## master #1030 +/- ##
==========================================
- Coverage 92.05% 92.03% -0.02%
==========================================
Files 53 53
Lines 5112 5112
Branches 1142 1141 -1
==========================================
- Hits 4706 4705 -1
- Misses 406 407 +1
Continue to review full report at Codecov.
|
|
@JeromeDeLeon This should fix your issue. Can you verify it? |
|
@dplewis Thanks. I was able to run it with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1021, #1027
Moves abort event to prevent xhr.open from calling it.
Ensure requestTask is set after the request sends.