Fixes logo don't being added to /out #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Can you check the Travis logs? It’s failing. |
|
Mmm I think it has to do with the capital A in "Assets", it should be "assets" (no capital A) to keep consistency naming across the rest of the repo, but i think you cant rename a folder in git fs just for the cases, so Ill change the config to check if travis finds the folder this way (I guess linux is more sensible to name casing) |
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 53 53
Lines 5114 5114
Branches 1142 1142
=======================================
Hits 4711 4711
Misses 403 403Continue to review full report at Codecov.
|
|
@dplewis fixed. Travis is happy now 😄 |
dplewis
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Parse logo is not showing when visiting (which I find my self visiting dozens of time a day 😅 )
Solution
jsdoc-conf.js is not being told the assets folder needs to be copied into the output folder
and for it to properly work as we expect, we need to move the logo image down into /assets/img.
Readme.md needs to point to "/img/logo_large.png" to get the logo from "/out/img".
Extra
Replacing space by underscore character in "logo large.png" file, so its now "logo_large.png"
.
.
Working logo being shown after this fix: