Skip to content

Fix file upload progress #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 19 additions & 3 deletions src/RESTController.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,15 +158,31 @@ const RESTController = {
for (const key in customHeaders) {
headers[key] = customHeaders[key];
}
xhr.onprogress = (event) => {
if(options && typeof options.progress === 'function') {

function handleProgress(event) {
if (options && typeof options.progress === 'function') {
if (event.lengthComputable) {
options.progress(event.loaded / event.total, event.loaded, event.total);
options.progress(
event.loaded / event.total,
event.loaded,
event.total
);
} else {
options.progress(null);
}
}
}

xhr.onprogress = (event) => {
handleProgress(event);
};

if (xhr.upload) {
xhr.upload.onprogress = (event) => {
handleProgress(event);
}
}

xhr.open(method, url, true);

for (const h in headers) {
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/ParseFile-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jest.setMock('../LocalDatastore', mockLocalDatastore);
function generateSaveMock(prefix) {
return function(name, payload, options) {
if (options && typeof options.progress === 'function') {
options.progress(0.5);
options.progress(0.5, 5, 10);
}
return Promise.resolve({
name: name,
Expand Down Expand Up @@ -236,7 +236,7 @@ describe('ParseFile', () => {
jest.spyOn(options, 'progress');

return file.save(options).then(function(f) {
expect(options.progress).toHaveBeenCalledWith(0.5);
expect(options.progress).toHaveBeenCalledWith(0.5, 5, 10);
expect(f).toBe(file);
expect(f.name()).toBe('progress.txt');
expect(f.url()).toBe('http://files.parsetfss.com/a/progress.txt');
Expand Down
3 changes: 2 additions & 1 deletion src/__tests__/RESTController-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ describe('RESTController', () => {
CoreManager.set('SERVER_AUTH_TOKEN', null);
});

it('reports upload progress of the AJAX request when callback is provided', (done) => {
it('reports upload/download progress of the AJAX request when callback is provided', (done) => {
const xhr = mockXHR([{ status: 200, response: { success: true } }], {
progress: {
lengthComputable: true,
Expand All @@ -445,6 +445,7 @@ describe('RESTController', () => {

RESTController.ajax('POST', 'files/upload.txt', {}, {}, options).then(({ response, status }) => {
expect(options.progress).toHaveBeenCalledWith(0.5, 5, 10);
expect(options.progress).toHaveBeenCalledTimes(2);
expect(response).toEqual({ success: true });
expect(status).toBe(200);
done();
Expand Down
2 changes: 2 additions & 0 deletions src/__tests__/test_helpers/mockXHR.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@ function mockXHR(results, options = {}) {
XHR.prototype = {
open: function() { },
setRequestHeader: function() { },
upload: function() { },
send: function() {
this.status = results[attempts].status;
this.responseText = JSON.stringify(results[attempts].response || {});
this.readyState = 4;
attempts++;
this.onreadystatechange();
this.onprogress(options.progress);
this.upload.onprogress(options.progress);
}
};
return XHR;
Expand Down