Skip to content

docs: wrong description for Parse.User.requestEmailVerification method #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2022

Conversation

okobsamoht
Copy link
Contributor

New Pull Request Checklist

Description

In the api reference documentation the Parse.User.requestEmailVerification and the Parse.User.requestPasswordReset have the exact same descrition for the email parameter.

  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 26, 2022

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title wrong description in Request an email verification doc docs: wrong description in Request an email verification doc May 26, 2022
@mtrezza mtrezza changed the title docs: wrong description in Request an email verification doc docs: wrong description for requestEmailVerification method May 26, 2022
@mtrezza mtrezza changed the title docs: wrong description for requestEmailVerification method docs: wrong description for requestEmailVerification method May 26, 2022
@mtrezza mtrezza changed the title docs: wrong description for requestEmailVerification method docs: wrong description for Parse.User.requestEmailVerification method May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1485 (f9b9190) into alpha (3d39708) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            alpha    #1485   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          61       61           
  Lines        5949     5949           
  Branches     1357     1357           
=======================================
  Hits         5946     5946           
  Misses          3        3           
Impacted Files Coverage Δ
src/ParseUser.js 99.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d39708...f9b9190. Read the comment docs.

@mtrezza mtrezza merged commit 00190aa into parse-community:alpha May 27, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.4.3-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.4.3-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 18, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.4.3

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants