-
-
Notifications
You must be signed in to change notification settings - Fork 597
docs: Fix incorrect return type in Parse.Object.getACL
#2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## alpha #2006 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 61 61
Lines 6122 6122
Branches 1493 1493
=========================================
Hits 6122 6122
☔ View full report in Codecov by Sentry. |
Thanks for opening this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could we add the TS notation for this as well - or would that balloon this PR?
Parse.Object.getACL
return type documentationParse.Object.getACL
return type documentation
Parse.Object.getACL
return type documentationParse.Object.getACL
Parse.Object.getACL
Parse.Object.getACL
It would balloon as you would have to do the entire file also this PR just focuses on JS Docs |
I though that could be done on a per-method basis - alright then. |
🎉 This change has been released in version 4.2.0-alpha.7 |
🎉 This change has been released in version 4.3.0-beta.1 |
🎉 This change has been released in version 4.3.0-alpha.1 |
🎉 This change has been released in version 4.3.0 |
Pull Request
Issue
Fixing
getACL
type to match PHP SDK getACLCloses: #1949
I also ran into an issue testing
npm run docs
Tasks