Fix async tests in ParseFile-test.js #374
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 84.35% 85.38% +1.02%
==========================================
Files 46 46
Lines 3663 3702 +39
Branches 835 846 +11
==========================================
+ Hits 3090 3161 +71
+ Misses 573 541 -32
Continue to review full report at Codecov.
|
|
Thanks for catching that one! |
Not sure how widespread of a problem this is, but I recently submitted a PR for ParseFile and noticed that some of the tests for it were not handling async properly and weren't actually executing assertions. This PR addresses ParseFile's tests only.