Skip to content

Updates docs generation template #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2018
Merged

Updates docs generation template #635

merged 1 commit into from
Aug 10, 2018

Conversation

flovilmart
Copy link
Contributor

before after
capture d ecran le 2018-08-10 a 14 28 49 capture d ecran le 2018-08-10 a 14 28 34

@flovilmart flovilmart requested review from acinader and dplewis August 10, 2018 18:30
@codecov
Copy link

codecov bot commented Aug 10, 2018 •
edited
Loading

Codecov Report

Merging #635 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files          48       48           
  Lines        3850     3850           
  Branches      871      871           
=======================================
  Hits         3272     3272           
  Misses        578      578

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e69f39...0e692b3. Read the comment docs.

@dplewis
Copy link
Member

dplewis commented Aug 10, 2018

Is there a specific reason why you changed the template?

On mobile they both look the same. On desktop the Before has better padding. After has better font.

@flovilmart
Copy link
Contributor Author

The template has a fix for the generation for Parse server :) also it’s a fork on our repo so we can gradually make it look better for all docs

dplewis
dplewis reviewed Aug 10, 2018
View reviewed changes
package.json
@@ -33,6 +33,7 @@
"xmlhttprequest": "1.8.0"
},
"devDependencies": {
"@parse/minami": "^1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I was wondering where this came from, I didn't see the fork.

Should this build against the master branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nijikokun/minami@master...parse-community:master

it's published already as an Npm package so we're good.

@flovilmart flovilmart merged commit 6d5112a into master Aug 10, 2018
@flovilmart flovilmart deleted the update-docs-template branch August 10, 2018 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplewis dplewis dplewis approved these changes

@acinader acinader Awaiting requested review from acinader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flovilmart @dplewis