Skip to content

Add a warning in 2.0.0.md about Promise.finally #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2018

Conversation

SebC99
Copy link
Contributor

@SebC99 SebC99 commented Aug 11, 2018

Whereas Parse.Promise.always, Promise.finally callback don't receive any arguments, and don't resolve with a new argument to pass to the next promise in chain.

@codecov
Copy link

codecov bot commented Aug 11, 2018

Codecov Report

Merging #636 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files          48       48           
  Lines        3853     3853           
  Branches      871      871           
=======================================
  Hits         3278     3278           
  Misses        575      575

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000c1fb...b533eaa. Read the comment docs.

Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That helps!

@flovilmart flovilmart merged commit 506bc83 into parse-community:master Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants