-
-
Notifications
You must be signed in to change notification settings - Fork 261
Made ParseClient.ConvertTo() a public API. #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm totally OK with this and this is something that currently only exists in .NET SDK. Question for the other team members:
|
iOS/OSX/watchOS/tvOS - simply type casting works great. |
Don't we already convert known datatypes? https://github.com/ParsePlatform/Parse-SDK-Android/blob/master/Parse/src/main/java/com/parse/ParseCloudCodeController.java#L45 We don't really allow deserializing from user JSON since odd things can happen, so I'm really wary of this. Lastly, +1 to it oddly being on |
Don't feel strongly too. +1 for move it in to |
What's the problem we're solving here? ParseCloud should be returning decoded responses. |
@grantland We're solving an issue with .NET's generic type system. When we decode from the server, we give back a dictionary of type This becomes more useful as you get a deeper nested structure, as at each level you'll be dealing with either Also, we don't have a |
73c9d86
to
880c5c3
Compare
@richardjrossiii, thanks for the clarification. I am OK with this change on .NET. But probably we do not need this in Android. |
ConvertTo's functionality is useful for external developers if they ever have to deal with CloudCode, or coercing other types return from the SDK. Fixes #67.
880c5c3
to
5f0c45a
Compare
Hey guys, I just updated the PR to move the utility into the |
/// <summary> | ||
/// A set of utilities for converting generic types between each other. | ||
/// </summary> | ||
public static class Conversion { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot the end result of our discussion. Do we want this to be public
or just want to separate this out and mark as "pending decision whether we want to make it public/make it separate .dll or do nothing and leave it here"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want it public for now, if we decide to do it as a separate project/repository, we'll make it a dependency, and it would stay under the same namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
I like the direction we're going here. Several cleanup and one major question. |
I think I addressed all of your comments in various replies, but I forgot to pass it back. Whoops. |
Made ParseClient.ConvertTo() a public API.
ConvertTo's functionality is useful for external developers if they ever have to deal with CloudCode, or coercing other types return from the SDK.
Fixes #67.