Skip to content

Fix saving ParseObjects with Pointers as properties #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2021
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jun 18, 2021

Close #168

  • Don't skip any key when encoding Pointers
  • Add test cases
  • Add playgrounds example
  • Add entry in changelog
  • Prepare for release

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #169 (d2ed16a) into main (c8ae80e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   82.17%   82.20%   +0.03%     
==========================================
  Files          70       70              
  Lines        6596     6596              
==========================================
+ Hits         5420     5422       +2     
+ Misses       1176     1174       -2     
Impacted Files Coverage Δ
Sources/ParseSwift/Coding/ParseEncoder.swift 75.16% <100.00%> (+0.32%) ⬆️
Sources/ParseSwift/Types/Pointer.swift 80.00% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 81.52% <0.00%> (-0.16%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 77.54% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ae80e...d2ed16a. Read the comment docs.

@cbaker6 cbaker6 merged commit f877b37 into main Jun 19, 2021
@cbaker6 cbaker6 deleted the playgroundPointer branch June 19, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keys being skipped when saving embedded Pointer
1 participant