Skip to content

Query withinMiles and withinKilometers can return unsorted results #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Aug 29, 2021

withinMiles and withinKilometers wasn't passing sort to withinRadians preventing a developer to request unsorted data.

  • pass sort to withinRadians
  • removed return from some one-liner queries
  • added test cases for fixes
  • added change log entry
  • prepare for release

@codecov
Copy link

codecov bot commented Aug 29, 2021

Codecov Report

Merging #219 (b54a90a) into main (38bbd01) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   83.55%   83.57%   +0.02%     
==========================================
  Files          76       76              
  Lines        7259     7265       +6     
==========================================
+ Hits         6065     6072       +7     
+ Misses       1194     1193       -1     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/Query.swift 95.15% <100.00%> (+0.04%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 78.09% <0.00%> (-0.26%) ⬇️
Sources/ParseSwift/Coding/ParseEncoder.swift 76.29% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bbd01...b54a90a. Read the comment docs.

@cbaker6 cbaker6 merged commit f6b2230 into main Aug 29, 2021
@cbaker6 cbaker6 deleted the geoQuery branch August 29, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant