-
-
Notifications
You must be signed in to change notification settings - Fork 516
Add Android Polygon and Full Text #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@montymxb Can you look this over? |
_includes/android/geopoints.md
Outdated
@@ -16,6 +16,42 @@ This point is then stored in the object as a regular field. | |||
placeObject.put("location", point); | |||
``` | |||
|
|||
To retrieved `ParseGeoPoint` from an object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo:
To retrieve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add some punctuation at the end of object
as well.
_includes/android/geopoints.md
Outdated
placeObject.put("bounds", polygon); | ||
``` | ||
|
||
To retrieved `ParsePolygon` from an object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo:
To retrieve
Punctuation afterobject
as well.
_includes/android/queries.md
Outdated
|
||
* Note: Full Text Search can be resource intensive. Ensure the cost of using indexes is worth the benefit, see [storage requirements & performance costs of text indexes.](https://docs.mongodb.com/manual/core/index-text/#storage-requirements-and-performance-costs). | ||
|
||
* Parse Server 2.5.0+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should state
Requires Parse Server 2.5.0+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few typos, stylistic suggestions. Rest looks good.
@montymxb Changes made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still those 2 things, should be good after that.
_includes/android/geopoints.md
Outdated
@@ -16,6 +16,42 @@ This point is then stored in the object as a regular field. | |||
placeObject.put("location", point); | |||
``` | |||
|
|||
To retrieved `ParseGeoPoint` from an object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to correct retrieved to retrieve. To improve the wording could be
To retrieve a
ParseGeoPoint
from an object.
_includes/android/geopoints.md
Outdated
placeObject.put("bounds", polygon); | ||
``` | ||
|
||
To retrieved `ParsePolygon` from an object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome , we're all good!
Sweet! |
Closes: #466
I also fixed some aggregate rest docs.