Skip to content

Add Android Polygon and Full Text #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2018

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jan 20, 2018

Closes: #466

I also fixed some aggregate rest docs.

@dplewis
Copy link
Member Author

dplewis commented Jan 20, 2018

@montymxb Can you look this over?

@@ -16,6 +16,42 @@ This point is then stored in the object as a regular field.
placeObject.put("location", point);
```

To retrieved `ParseGeoPoint` from an object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo:

To retrieve

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add some punctuation at the end of object as well.

placeObject.put("bounds", polygon);
```

To retrieved `ParsePolygon` from an object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo:

To retrieve
Punctuation after object as well.


* Note: Full Text Search can be resource intensive. Ensure the cost of using indexes is worth the benefit, see [storage requirements & performance costs of text indexes.](https://docs.mongodb.com/manual/core/index-text/#storage-requirements-and-performance-costs).

* Parse Server 2.5.0+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should state

Requires Parse Server 2.5.0+

Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos, stylistic suggestions. Rest looks good.

@dplewis
Copy link
Member Author

dplewis commented Jan 21, 2018

@montymxb Changes made

@dplewis dplewis closed this Jan 21, 2018
@dplewis dplewis reopened this Jan 21, 2018
Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still those 2 things, should be good after that.

@@ -16,6 +16,42 @@ This point is then stored in the object as a regular field.
placeObject.put("location", point);
```

To retrieved `ParseGeoPoint` from an object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to correct retrieved to retrieve. To improve the wording could be

To retrieve a ParseGeoPoint from an object.

placeObject.put("bounds", polygon);
```

To retrieved `ParsePolygon` from an object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here.

Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :octocat: , we're all good!

@dplewis
Copy link
Member Author

dplewis commented Jan 21, 2018

Sweet!

@montymxb montymxb merged commit 57a89f5 into parse-community:gh-pages Jan 22, 2018
@dplewis dplewis deleted the android-polygon branch January 22, 2018 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Polygon docs (Android)
2 participants