Skip to content

fix: Move taffydb from dev dependencies #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2023
Merged

fix: Move taffydb from dev dependencies #3

merged 1 commit into from
Oct 1, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Sep 28, 2023

Documentation generation is currently broken.

FATAL: Unable to load template: Cannot find module 'taffydb'
Require stack:
- /Users/dplewis/Documents/GitHub/Parse-SDK-JS/node_modules/@parse/minami/publish.js
- /Users/dplewis/Documents/GitHub/Parse-SDK-JS/node_modules/jsdoc/cli.js
- /Users/dplewis/Documents/GitHub/Parse-SDK-JS/node_modules/jsdoc/jsdoc.js

@dplewis
Copy link
Member Author

dplewis commented Sep 28, 2023

@mtrezza

@dplewis dplewis mentioned this pull request Sep 28, 2023
Merged
@mtrezza
Copy link
Member

mtrezza commented Sep 29, 2023

Is this PR a fix? It only seems to remove the range version range operator, so I assume it uses a newer version; but what is that newer version?

@dplewis
Copy link
Member Author

dplewis commented Sep 30, 2023

This is a fix, devDependencies aren’t published and therefore not found. I moved this to production dependency. I just pinned the package just to be safe, 2.7.3 is the latest version

mtrezza
mtrezza approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza changed the title chore: Move taffydb from dev dependencies fix: Move taffydb from dev dependencies Oct 1, 2023
@mtrezza mtrezza merged commit 2e8529b into parse-community:main Oct 1, 2023
@dplewis dplewis deleted the dep-move branch October 2, 2023 00:44
@dplewis dplewis restored the dep-move branch October 3, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dplewis @mtrezza