Skip to content

feat: add Node 18 support #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 12, 2022
Merged

feat: add Node 18 support #2206

Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
72e64bf
feat: Remove Node12 Add Node18 from CI
MrMartinR Jul 4, 2022
198696b
feat: change NODE_VERSION, remove test old ver.
MrMartinR Jul 4, 2022
cbe062b
Put Node 12 back
MrMartinR Jul 4, 2022
1f55be0
Change ver 18 to 18.4.0
MrMartinR Jul 4, 2022
c25351b
Put back test commands
MrMartinR Jul 4, 2022
7280279
change default version to 16.10.0
MrMartinR Jul 4, 2022
a7d0025
Merge branch 'alpha' into CI-Node18
mtrezza Jul 6, 2022
d273af1
change default version to 18.4.0
MrMartinR Jul 7, 2022
e4f87c7
change ubuntu-18.04 to ubuntu-latest
MrMartinR Jul 8, 2022
f212245
update 18.4.0 to 18.5.0
MrMartinR Jul 9, 2022
4703505
Merge branch 'alpha' into CI-Node18
mtrezza Jul 11, 2022
76ba165
Merge branch 'alpha' into CI-Node18
MrMartinR Jul 11, 2022
2fbb390
Merge branch 'alpha' into CI-Node18
mtrezza Sep 12, 2022
252738a
Merge branch 'alpha' into CI-Node18
mtrezza Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
branches:
- '**'
env:
NODE_VERSION: 16.10.0
NODE_VERSION: 18.0.0
jobs:
check-ci:
name: Node Engine Check
Expand Down Expand Up @@ -117,6 +117,8 @@ jobs:
NODE_VERSION: 14.19.2
- name: Node 16
NODE_VERSION: 16.10.0
- name: Node 18
NODE_VERSION: 18.0.0
fail-fast: false
name: ${{ matrix.name }}
timeout-minutes: 15
Expand All @@ -143,12 +145,6 @@ jobs:
key: ${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-${{ matrix.NODE_VERSION }}-
- name: Install dependencies (Node < 10)
run: npm install
if: ${{ steps.node.outputs.node_major < 10 }}
- name: Install dependencies (Node >= 10)
run: npm ci
if: ${{ steps.node.outputs.node_major >= 10 }}
- name: Tests
run: npm test
- name: Test bundles
Expand Down