-
-
Notifications
You must be signed in to change notification settings - Fork 342
ParseObject encode/decode #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age in encode/decode for ParseObject
…igits natively in php and 3 digits in parse storage
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 98.61% 98.93% +0.31%
==========================================
Files 35 35
Lines 3178 3281 +103
==========================================
+ Hits 3134 3246 +112
+ Misses 44 35 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes to add new encode and decode to the ParseObject class. These would be separate from the previously existing
ParseObject::_encode
, which remains unmodified in terms of prior behavior.This is essentially a lighter and more integrated approach as opposed just using
serialize
andunserialize
. Through this an object could be encoded or decoded as follows.Currently this will preserve saved and unsaved values, allowing you to encode an object with unsaved changes preserved until later decoded.
A few notes as to how this works with specific values:
stdClass
, but not ParseObjects, ParsePolygons, ParseGeoPoints, etc.) will be encoded to JSON if possible and returned as an array value (this is how it works currently)As it stands this is good to go. The only issue being about preserving the pending set of operations that have been applied to an object (like the aforementioned concern of unsaved additions/removals in a relation). I might still make a few changes yet, and if I have the time I may make the change to support pending ops.
This also includes a small style change to the README.