Skip to content

Make ServerInfo tests flexible to Server values #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

montymxb
Copy link
Contributor

@montymxb montymxb commented Nov 4, 2017

Depending on which version of parse-server you may be running these tests could fail just because of the strict requirements on feature config values. This keeps the checks, but instead of relying on their values it simply checks to make sure they are present. As features availability changes these tests will still pass then, so long as no existing features are pulled.

@montymxb montymxb added this to the 1.4.0 milestone Nov 4, 2017
@codecov
Copy link

codecov bot commented Nov 4, 2017

Codecov Report

Merging #367 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          36       36           
  Lines        3389     3389           
=======================================
  Hits         3353     3353           
  Misses         36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9324d19...b79aef6. Read the comment docs.

@montymxb montymxb merged commit 9f3dffe into parse-community:master Nov 7, 2017
@montymxb montymxb deleted the server-info-test-changes branch November 7, 2017 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant