make less un-useful noise with bad responses #388
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montymxb
suggested changes
Feb 27, 2018
There was a problem hiding this comment.
@mtopolski the CI failure looks unrelated, I'll handle that seperately of this PR.
Regarding this addition, the single change looks good 👍 . My one nit is if you can elaborate on a repeatable case that causes this. Assuming it's straightforward to recreate, I would want to have a single test added to enforce this behavior on bad requests w/ curl exceptions disabled. You can add the necessary test case here.
dplewis
added a commit
to dplewis/parse-php-sdk
that referenced
this pull request
Dec 4, 2018
dplewis
added a commit
that referenced
this pull request
Dec 4, 2018
|
Superced by #425 Thanks @mtopolski for starting on the PR🙏 |
|
The label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
ParseClient::_request()gets a bad response andself::$enableCurlExceptionsis not enabled whenParseQuery::find()runs it creates PHP warnings because it's trying to foreach a bool. This should help prevent some non useful noise.