When creating a ParseUser instance, be sure to use static to get registered subclasses. #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stered subclasses.
|
@montymxb, unfortunately, unit tests are failing on master due to an npm install issue..... |
|
Gotcha, I'll look into that today. Other than the CI issue the changes look good 👍 , thanks for catching those. I'll see if I can resolve the CI thing before we take this in. |
|
@montymxb do you want me to merge this? |
|
@acinader Yeah that's fine. Still need to resolve the CI issue, but we can do that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #84
This just eliminates two other places where ParseUser is called instead of using the subclass's static constructor.