Fix queries equalTo with null values #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 98.97% 98.97% -0.01%
==========================================
Files 38 38
Lines 3117 3114 -3
==========================================
- Hits 3085 3082 -3
Misses 32 32
Continue to review full report at Codecov.
|
zeliard91
added a commit
to zeliard91/DoctrineParseBundle
that referenced
this pull request
Jul 31, 2018
Temp fix waiting PR parse-community/parse-php-sdk#406 approval
dplewis
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This fix is meant to correct the behavior when we do an ->equalTo(null) ParseQuery.
Before that, it used ->doesNotExist($key) which can work if the attribute has never been set, but if the attribute is set and equals to NULL, then it does not match.
The only workaround I found to effectively query on NULL values before this patch is to do an ->notContainedIn($key, [null]) which is not pretty and not accurate.
I think there is no reason to replace a "IS NULL" query part by a "DOES NOT EXISTS", they both mean something different and the SDK users must choose one or the other according to their needs.