Skip to content

⚡️ Release 1.6.0 #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 17, 2019
Merged

⚡️ Release 1.6.0 #447

merged 5 commits into from
Aug 17, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 19, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #447 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #447   +/-   ##
=========================================
  Coverage     96.98%   96.98%           
  Complexity     1058     1058           
=========================================
  Files            39       39           
  Lines          2950     2950           
=========================================
  Hits           2861     2861           
  Misses           89       89
Impacted Files Coverage Δ Complexity Δ
src/Parse/ParseClient.php 92.95% <ø> (ø) 97 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942dcc2...1704e57. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Jul 21, 2019

@acinader i have one more PR to add to this. Is releasing the same as the other SDKs? Do you need to change the deployment keys?

@acinader
Copy link
Contributor

Hi Diamond,

Yes, it looks like $GITHUB_TOKEN is now missing so the sdk docs will fail to post to gh-pages.

I've been using travis encrypt instead.

The reason being that:

a) it's what I use for my job
b) since it is under git, we can see who committed and when, and any changes are visible in history (even if they're encrypted so you can't read em)

is that ok with you? do you have permissions to travis encrypt in that repo? If not, let's that setup for you?

@dplewis
Copy link
Member Author

dplewis commented Jul 22, 2019

That’s perfectly fine. I’ll leave it up to you. I’ve seen you change them it in other SDKs.

@acinader
Copy link
Contributor

looks like i've been publishing it i think. i'll look into how to script it with travis.

@acinader
Copy link
Contributor

@dplewis is this waiting on me?

@dplewis
Copy link
Member Author

dplewis commented Aug 17, 2019

Yes sir

@dplewis dplewis merged commit fa132ca into master Aug 17, 2019
@dplewis dplewis deleted the 1.6.0 branch August 17, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants