Skip to content

feat: Add support for PHP 8.1, 8.2 #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 26, 2023
Merged

feat: Add support for PHP 8.1, 8.2 #489

merged 4 commits into from
Apr 26, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 22, 2023 •
edited
Loading

New Pull Request Checklist

Issue Description

Migrate TravisCI to Github Actions

Closes: #479, #488

Approach

  • Support PHP 8.1, 8.2
  • Drop support for <= 8.0
  • Remove travis
  • Bump composer packages
  • Remove mailgun adapter
  • Remove warnings
  • Remove deprecation warnings
  • Support for Parse Server 6
  • Fix flaky tests
  • Add documentation deployment

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add changelog entry

@dplewis
ci: Migrate to Github Actions
8da150a 
fix user tests

fix tests

lint

run server in background

rebuild package.lock

add composer lock

fix CI

remove travis

lint ci.yml

ci: Migrate to Github Actions
@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 22, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dplewis dplewis closed this Apr 22, 2023
@dplewis dplewis reopened this Apr 22, 2023
@dplewis dplewis requested a review from mtrezza April 22, 2023 10:32
@codecov
Copy link

codecov bot commented Apr 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.20 ⚠️

Comparison is base (184460b) 98.07% compared to head (86df298) 97.88%.

❗ Current head 86df298 differs from pull request most recent head 57b8d4f. Consider uploading reports for the commit 57b8d4f to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #489      +/-   ##
============================================
- Coverage     98.07%   97.88%   -0.20%     
- Complexity     1063     1066       +3     
============================================
  Files            39       39              
  Lines          2964     3262     +298     
============================================
+ Hits           2907     3193     +286     
- Misses           57       69      +12
Impacted Files Coverage Δ
src/Parse/ParseUser.php 98.40% <ø> (+0.09%) ⬆️
src/Parse/HttpClients/ParseCurlHttpClient.php 95.50% <100.00%> (+0.15%) ⬆️
src/Parse/HttpClients/ParseStreamHttpClient.php 96.10% <100.00%> (-2.53%) ⬇️
src/Parse/ParseACL.php 100.00% <100.00%> (ø)
src/Parse/ParseQuery.php 99.52% <100.00%> (-0.24%) ⬇️

... and 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mtrezza
mtrezza reviewed Apr 22, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

mtrezza
mtrezza requested changes Apr 24, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #489 (comment)

@mtrezza mtrezza changed the title ci: Migrate to Github Actions feat: Add support for PHP 8.1, 8.2 Apr 25, 2023
@mtrezza
Copy link
Member

mtrezza commented Apr 25, 2023 •
edited
Loading

Changed this PR to feat since it changes the supported PHP versions and is therefore a breaking change.

mtrezza
mtrezza approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this PR, let's hope it motivates others to bring this SDK up-to-date.

@mtrezza mtrezza mentioned this pull request Apr 26, 2023
Closed
@mtrezza
Copy link
Member

mtrezza commented Apr 26, 2023 •
edited
Loading

@dplewis Do you remember how to prepare and publish a release in this repo?

Past commits to prepare releases only contain the changelog entry and bumping the internal client version that is sent to Parse Server in ParseClient.php.

For example fa132ca

We don't have auto-release in this repo yet. To add that, I'd like to understand the steps needed to publish it manually.

@dplewis
Copy link
Member Author

dplewis commented Apr 26, 2023

@mtrezza I have absolutely no idea how to publish this or how it works. I just do a tag and release and it magically publishes. @montymxb @acinader handled releases So they might know

@mtrezza
Copy link
Member

mtrezza commented Apr 26, 2023

I've opened #492 to find out more about release publishing.

@mtrezza mtrezza merged commit d5783e3 into parse-community:master Apr 26, 2023
This was referenced Apr 26, 2023
Closed
Closed
@dplewis dplewis deleted the github-actions branch April 27, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error for PHP 8 : Required parameter $auth_token follows optional parameter $consumer_secret
2 participants
@dplewis @mtrezza