Skip to content

PSR-2 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

PSR-2 #80

wants to merge 1 commit into from

Conversation

hipsterjazzbo
Copy link
Contributor

As discussed in #79

allthethings.jpg
This was referenced Mar 11, 2015
@hipsterjazzbo
Copy link
Contributor Author

@gfosco Any chance of getting this merged soon? I've got one more PR that fixes #42 and then I can release this sweet Laravel integration package I've written :)

@hipsterjazzbo
Copy link
Contributor Author

@gfosco @GrahamCampbell knock knock This thing on?

@gfosco
Copy link
Contributor

gfosco commented Mar 31, 2015

Sorry, I didn't get to this in time (reviewing it is a pain due to the widespread changes...) and we added the Sessions API last week, so this can't be merged now. I will use Style CI and submit a new PR.

@hipsterjazzbo
Copy link
Contributor Author

Awesome! I've got a PR that fixes user subclassing, but I did in PSR-2 so when you've done that I'll open it up. Thanks!

@gfosco
Copy link
Contributor

gfosco commented Mar 31, 2015

Merged #83. Thanks again for your contributions

@gfosco gfosco closed this Mar 31, 2015
@gfosco
Copy link
Contributor

gfosco commented Mar 31, 2015

Also, StyleCI is enabled for the repo, and all future PRs will be checked. :)

@hipsterjazzbo hipsterjazzbo deleted the psr-2 branch March 31, 2015 21:25
@GrahamCampbell
Copy link
Contributor

StyleCI didn't do a good job of the indentation changes. You should have really done that first, then let styleci do the rest.

@hipsterjazzbo
Copy link
Contributor Author

@GrahamCampbell Yeah I noticed that, but this has been done and merged separately by @gfosco in #83

@GrahamCampbell
Copy link
Contributor

@hipsterjazzbo That had to be reverted...

@GrahamCampbell
Copy link
Contributor

See #87.

@GrahamCampbell
Copy link
Contributor

and #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants