-
-
Notifications
You must be signed in to change notification settings - Fork 342
PSR-2 #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSR-2 #80
Conversation
allthethings.jpg
@gfosco @GrahamCampbell knock knock This thing on? |
Sorry, I didn't get to this in time (reviewing it is a pain due to the widespread changes...) and we added the Sessions API last week, so this can't be merged now. I will use Style CI and submit a new PR. |
Awesome! I've got a PR that fixes user subclassing, but I did in PSR-2 so when you've done that I'll open it up. Thanks! |
Merged #83. Thanks again for your contributions |
Also, StyleCI is enabled for the repo, and all future PRs will be checked. :) |
StyleCI didn't do a good job of the indentation changes. You should have really done that first, then let styleci do the rest. |
@GrahamCampbell Yeah I noticed that, but this has been done and merged separately by @gfosco in #83 |
@hipsterjazzbo That had to be reverted... |
See #87. |
and #88 |
As discussed in #79