Skip to content

feat: Add support for watchOS push notifications #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 18, 2025

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 17, 2025

New Pull Request Checklist

Issue Description

Closes: #361

Approach

Similar approach to #58

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

parse-github-assistant bot commented Jan 17, 2025

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5cd5170) to head (2578fe3).
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1296      1351   +55     
=========================================
+ Hits          1296      1351   +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Jan 17, 2025

@mtrezza this is ready for review

@mman
Copy link
Contributor

mman commented Jan 17, 2025

@cbaker6 Does parse server push config need to be modified in some way in order to support delivery to watchOS? I suppose it does and if so, could you please update it in the README? Thx!

@cbaker6
Copy link
Contributor Author

cbaker6 commented Jan 17, 2025

Does parse server push config need to be modified in some way in order to support delivery to watchOS? I suppose it does and if so, could you please update it in the README? Thx!

watchos needs to be added to the config. I updated the README in the commit 4cdbc82 to reflect watchOS similar to the other OS's. The README doesn't go into detail about how to configure. I assume you mean updating the overall Parse documentation here: https://docs.parseplatform.org/parse-server/guide/#push-notifications. I can open another PR for that (PR in docs is here: parse-community/docs#956)

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza changed the title feat: Add support for watchOS notifications feat: Add support for watchOS push notifications Jan 18, 2025
@mtrezza mtrezza merged commit 97f14ca into parse-community:master Jan 18, 2025
8 checks passed
parseplatformorg pushed a commit that referenced this pull request Jan 18, 2025
# [6.10.0](6.9.1...6.10.0) (2025-01-18)

### Features

* Add support for watchOS push notifications ([#360](#360)) ([97f14ca](97f14ca))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APNS should support watchOS push notifications
4 participants