chore(package): update jasmine to version 3.0.0 (#4553)

* chore(package): update jasmine to version 3.0.0

Closes #4547

* Fixes failing tests for jasmine 3.0

Starting 3.0, done(something) will fail

* Update tests so they dont leverage var, but let and const

With jasmine 3.0, the randomization engine was making the test fails because of the scope of `var`

* Remove randomizer

* Use same adapter for PG tests, drop table to ensure the tests dont side effect

Author: flovilmart

package.json

@@ -58,7 +58,7 @@
     "eslint-plugin-flowtype": "^2.39.1",
     "flow-bin": "^0.66.0",
     "gaze": "1.1.2",
-    "jasmine": "2.9.0",
+    "jasmine": "3.0.0",
     "jasmine-spec-reporter": "^4.1.0",
     "mongodb-runner": "3.6.1",
     "nodemon": "1.15.0",

spec/.eslintrc.json

@@ -28,6 +28,7 @@
       "arrayContains": true
     },
     "rules": {
-      "no-console": [0]
+      "no-console": [0],
+      "no-var": "error"
     }
 }

spec/AccountLockoutPolicy.spec.js

@@ -2,7 +2,7 @@
 
 const Config = require("../src/Config");
 
-var loginWithWrongCredentialsShouldFail = function(username, password) {
+const loginWithWrongCredentialsShouldFail = function(username, password) {
   return new Promise((resolve, reject) => {
     Parse.User.logIn(username, password)
       .then(() => reject('login should have failed'))
@@ -16,7 +16,7 @@ var loginWithWrongCredentialsShouldFail = function(username, password) {
   });
 };
 
-var isAccountLockoutError = function(username, password, duration, waitTime) {
+const isAccountLockoutError = function(username, password, duration, waitTime) {
   return new Promise((resolve, reject) => {
     setTimeout(() => {
       Parse.User.logIn(username, password)
@@ -40,7 +40,7 @@ describe("Account Lockout Policy: ", () => {
       publicServerURL: 'http://localhost:1337/1',
     })
       .then(() => {
-        var user = new Parse.User();
+        const user = new Parse.User();
         user.setUsername('username1');
         user.setPassword('password');
         return user.signUp(null);
@@ -215,7 +215,7 @@ describe("Account Lockout Policy: ", () => {
       publicServerURL: "http://localhost:8378/1"
     })
       .then(() => {
-        var user = new Parse.User();
+        const user = new Parse.User();
         user.setUsername("username2");
         user.setPassword("failedLoginAttemptsThreshold");
         return user.signUp();
@@ -248,7 +248,7 @@ describe("Account Lockout Policy: ", () => {
       publicServerURL: "http://localhost:8378/1"
     })
       .then(() => {
-        var user = new Parse.User();
+        const user = new Parse.User();
         user.setUsername("username3");
         user.setPassword("failedLoginAttemptsThreshold");
         return user.signUp();
@@ -285,7 +285,7 @@ describe("Account Lockout Policy: ", () => {
       publicServerURL: "http://localhost:8378/1"
     })
       .then(() => {
-        var user = new Parse.User();
+        const user = new Parse.User();
         user.setUsername("username4");
         user.setPassword("correct password");
         return user.signUp();

spec/AdaptableController.spec.js

@@ -1,18 +1,18 @@
 
-var AdaptableController = require("../src/Controllers/AdaptableController").AdaptableController;
-var FilesAdapter = require("../src/Adapters/Files/FilesAdapter").default;
-var FilesController = require("../src/Controllers/FilesController").FilesController;
+const AdaptableController = require("../src/Controllers/AdaptableController").AdaptableController;
+const FilesAdapter = require("../src/Adapters/Files/FilesAdapter").default;
+const FilesController = require("../src/Controllers/FilesController").FilesController;
 
-var MockController = function(options) {
+const MockController = function(options) {
   AdaptableController.call(this, options);
 }
 MockController.prototype = Object.create(AdaptableController.prototype);
 MockController.prototype.constructor = AdaptableController;
 
 describe("AdaptableController", ()=>{
   it("should use the provided adapter", (done) => {
-    var adapter = new FilesAdapter();
-    var controller = new FilesController(adapter);
+    const adapter = new FilesAdapter();
+    const controller = new FilesController(adapter);
     expect(controller.adapter).toBe(adapter);
     // make sure _adapter is private
     expect(controller._adapter).toBe(undefined);
@@ -23,7 +23,7 @@ describe("AdaptableController", ()=>{
   });
 
   it("should throw when creating a new mock controller", (done) => {
-    var adapter = new FilesAdapter();
+    const adapter = new FilesAdapter();
     expect(() => {
       new MockController(adapter);
     }).toThrow();
@@ -32,9 +32,9 @@ describe("AdaptableController", ()=>{
 
   it("should fail setting the wrong adapter to the controller", (done) => {
     function WrongAdapter() {}
-    var adapter = new FilesAdapter();
-    var controller = new FilesController(adapter);
-    var otherAdapter = new WrongAdapter();
+    const adapter = new FilesAdapter();
+    const controller = new FilesController(adapter);
+    const otherAdapter = new WrongAdapter();
     expect(() => {
       controller.adapter = otherAdapter;
     }).toThrow();
@@ -43,7 +43,7 @@ describe("AdaptableController", ()=>{
 
   it("should fail to instantiate a controller with wrong adapter", (done) => {
     function WrongAdapter() {}
-    var adapter = new WrongAdapter();
+    const adapter = new WrongAdapter();
     expect(() => {
       new FilesController(adapter);
     }).toThrow();
@@ -58,7 +58,7 @@ describe("AdaptableController", ()=>{
   });
 
   it("should accept an object adapter", (done) => {
-    var adapter = {
+    const adapter = {
       createFile: function() { },
       deleteFile: function() { },
       getFileData: function() { },
@@ -77,7 +77,7 @@ describe("AdaptableController", ()=>{
     AGoodAdapter.prototype.getFileData = function() { };
     AGoodAdapter.prototype.getFileLocation = function() { };
 
-    var adapter = new AGoodAdapter();
+    const adapter = new AGoodAdapter();
     expect(() => {
       new FilesController(adapter);
     }).not.toThrow();

spec/AdapterLoader.spec.js

@@ -1,16 +1,16 @@
 
-var loadAdapter = require("../src/Adapters/AdapterLoader").loadAdapter;
-var FilesAdapter = require("@parse/fs-files-adapter").default;
-var S3Adapter = require("@parse/s3-files-adapter").default;
-var ParsePushAdapter = require("@parse/push-adapter").default;
+const loadAdapter = require("../src/Adapters/AdapterLoader").loadAdapter;
+const FilesAdapter = require("@parse/fs-files-adapter").default;
+const S3Adapter = require("@parse/s3-files-adapter").default;
+const ParsePushAdapter = require("@parse/push-adapter").default;
 const Config = require('../src/Config');
 
 describe("AdapterLoader", ()=>{
 
   it("should instantiate an adapter from string in object", (done) => {
-    var adapterPath = require('path').resolve("./spec/MockAdapter");
+    const adapterPath = require('path').resolve("./spec/MockAdapter");
 
-    var adapter = loadAdapter({
+    const adapter = loadAdapter({
       adapter: adapterPath,
       options: {
         key: "value",
@@ -25,16 +25,16 @@ describe("AdapterLoader", ()=>{
   });
 
   it("should instantiate an adapter from string", (done) => {
-    var adapterPath = require('path').resolve("./spec/MockAdapter");
-    var adapter = loadAdapter(adapterPath);
+    const adapterPath = require('path').resolve("./spec/MockAdapter");
+    const adapter = loadAdapter(adapterPath);
 
     expect(adapter instanceof Object).toBe(true);
     done();
   });
 
   it("should instantiate an adapter from string that is module", (done) => {
-    var adapterPath = require('path').resolve("./src/Adapters/Files/FilesAdapter");
-    var adapter = loadAdapter({
+    const adapterPath = require('path').resolve("./src/Adapters/Files/FilesAdapter");
+    const adapter = loadAdapter({
       adapter: adapterPath
     });
 
@@ -47,7 +47,7 @@ describe("AdapterLoader", ()=>{
   });
 
   it("should instantiate an adapter from npm module", (done) => {
-    var adapter = loadAdapter({
+    const adapter = loadAdapter({
       module: '@parse/fs-files-adapter'
     });
 
@@ -60,69 +60,69 @@ describe("AdapterLoader", ()=>{
   });
 
   it("should instantiate an adapter from function/Class", (done) => {
-    var adapter = loadAdapter({
+    const adapter = loadAdapter({
       adapter: FilesAdapter
     });
     expect(adapter instanceof FilesAdapter).toBe(true);
     done();
   });
 
   it("should instantiate the default adapter from Class", (done) => {
-    var adapter = loadAdapter(null, FilesAdapter);
+    const adapter = loadAdapter(null, FilesAdapter);
     expect(adapter instanceof FilesAdapter).toBe(true);
     done();
   });
 
   it("should use the default adapter", (done) => {
-    var defaultAdapter = new FilesAdapter();
-    var adapter = loadAdapter(null, defaultAdapter);
+    const defaultAdapter = new FilesAdapter();
+    const adapter = loadAdapter(null, defaultAdapter);
     expect(adapter instanceof FilesAdapter).toBe(true);
     done();
   });
 
   it("should use the provided adapter", (done) => {
-    var originalAdapter = new FilesAdapter();
-    var adapter = loadAdapter(originalAdapter);
+    const originalAdapter = new FilesAdapter();
+    const adapter = loadAdapter(originalAdapter);
     expect(adapter).toBe(originalAdapter);
     done();
   });
 
   it("should fail loading an improperly configured adapter", (done) => {
-    var Adapter = function(options) {
+    const Adapter = function(options) {
       if (!options.foo) {
         throw "foo is required for that adapter";
       }
     }
-    var adapterOptions = {
+    const adapterOptions = {
       param: "key",
       doSomething: function() {}
     };
 
     expect(() => {
-      var adapter = loadAdapter(adapterOptions, Adapter);
+      const adapter = loadAdapter(adapterOptions, Adapter);
       expect(adapter).toEqual(adapterOptions);
     }).not.toThrow("foo is required for that adapter");
     done();
   });
 
   it("should load push adapter from options", (done) => {
-    var options = {
+    const options = {
       android: {
         senderId: 'yolo',
         apiKey: 'yolo'
       }
     }
     expect(() => {
-      var adapter = loadAdapter(undefined, ParsePushAdapter, options);
+      const adapter = loadAdapter(undefined, ParsePushAdapter, options);
       expect(adapter.constructor).toBe(ParsePushAdapter);
       expect(adapter).not.toBe(undefined);
     }).not.toThrow();
     done();
   });
 
   it("should load custom push adapter from string (#3544)", (done) => {
-    var adapterPath = require('path').resolve("./spec/MockPushAdapter");
-    var options = {
+    const adapterPath = require('path').resolve("./spec/MockPushAdapter");
+    const options = {
       ios: {
         bundleId: 'bundle.id'
       }
@@ -145,9 +145,9 @@ describe("AdapterLoader", ()=>{
   });
 
   it("should load S3Adapter from direct passing", (done) => {
-    var s3Adapter = new S3Adapter("key", "secret", "bucket")
+    const s3Adapter = new S3Adapter("key", "secret", "bucket")
     expect(() => {
-      var adapter = loadAdapter(s3Adapter, FilesAdapter);
+      const adapter = loadAdapter(s3Adapter, FilesAdapter);
       expect(adapter).toBe(s3Adapter);
     }).not.toThrow();
     done();

spec/Analytics.spec.js

@@ -16,7 +16,7 @@ describe('AnalyticsController', () => {
       })
     }).then(() => {
       expect(analyticsAdapter.trackEvent).toHaveBeenCalled();
-      var lastCall = analyticsAdapter.trackEvent.calls.first();
+      const lastCall = analyticsAdapter.trackEvent.calls.first();
       const args = lastCall.args;
       expect(args[0]).toEqual('MyEvent');
       expect(args[1]).toEqual({
@@ -44,7 +44,7 @@ describe('AnalyticsController', () => {
       })
     }).then(() => {
       expect(analyticsAdapter.appOpened).toHaveBeenCalled();
-      var lastCall = analyticsAdapter.appOpened.calls.first();
+      const lastCall = analyticsAdapter.appOpened.calls.first();
       const args = lastCall.args;
       expect(args[0]).toEqual({
         dimensions: {