Add Cache-Control support for Parse.Files / FilesRouter

[andresgarza]

Currently, the FilesRouter sets no response headers other that the Content-Type of the file being requested. It would be great if we could somehow configure also sending a Cache-Control header for file requests.

One idea would be for each Parse.File to specify its cache mechanism (by default it could have caching disabled). Another idea is to have a "global" caching mechanism that could work as a default.

I would gladly help submitting a PR if someone could point me in the right direction :)

[drew-gross]

This is a great idea. @skinp has done most of our files related code, hopefully he can point out where this might be added.

[KBog]

Any update on this?

I implemented CloudFront support using my AWS S3 storage. But running the PageSpeed Insights from Google suggests that my files don't have Cache-Control: (expiration not specified).

Thanks!

[flovilmart]

Not yet, but your could take over @KBog . Also you coud implement it into the https://github.com/parse-server-modules/parse-server-s3-adapter as a global cache control for all s3 uploaded files

[KBog]

Here's my attempt to add the global cache control as you suggested:
parse-community/parse-server-s3-adapter#13

I made the change locally at first (localhost), and was able to see (in Chrome debugger) the "Cache-Control" being added to newly saved Parse.Files.

Pardon any newbie mistakes, as I'm still a beginner when it comes to web/server dev :)

[flovilmart]

let's see how it goes!

[bchapin]

Has cache control been added to the current S3 adapter?

[KBog]

Yes, it's been out for a while. Tested it and working in our production app.

[KBog]

Should probably close this issue to avoid confusion.

[andresgarza]

I believe the cache-control only works if you are accessing the files directly through S3 (directAccess=true).

[yaaminu]

Is the cache control available for non S3 file adapters?

[montymxb]

Looks like this has been added to the S3 adapter but was never closed out. Taking care of it now, let us know if we're missing anything and this needs be reopened!