Fix for #1642 - copy query parameters to request body #1687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@steven-supersolid updated the pull request. |
Current coverage is 92.47%@@ master #1687 diff @@
==========================================
Files 87 87
Lines 6148 6149 +1
Methods 1062 1062
Messages 0 0
Branches 1260 1260
==========================================
+ Hits 5675 5686 +11
+ Misses 473 463 -10
Partials 0 0
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with query string parameters not being used on queries on _Installation. The bug does not exist in ClassesRouter. Issue is #1642
@nlutsenko
InstallationsRouter.handleFind has code duplicated from ClassesRouter.handleFind without some of the useful looking checks in ClassesRouter. It might make sense to refactor the common functionality out/up. I have just fixed the bug here and leave the refactoring for another day.