Refactor MongoTransform.js #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drew-gross
commented
May 17, 2016
drew-gross
commented
- Partially breaks dependency of MongoTransform on schemaController
- Lifts a lots of validation higher in the call tree. Ideally all validation would happen very early in the request.
- Fixes a lot of bugs involving keys in nested objects with names like "createdAt"
- Reduce the number of bool parameters in transform functions that do minor tweaks to how the function works.
ghost
added
the
| if (!(operator.objects instanceof Array)) { | ||
| throw new Parse.Error(Parse.Error.INVALID_JSON, | ||
| 'objects to add must be an array'); | ||
| if (!(objects instanceof Array)) { |
There was a problem hiding this comment.
Array.isArray vs instanceof Array
Which is the preferred method these days?
|
I'm going to merge this because I have other stuff that builds on it. If anyone has complaints, they can revert or submit a new PR before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.