Update schema mismatch error to include type string #1898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.79%@@ master #1898 diff @@
==========================================
Files 91 91
Lines 6396 6397 +1
Methods 1105 1105
Messages 0 0
Branches 1344 1345 +1
==========================================
+ Hits 5871 5872 +1
Misses 525 525
Partials 0 0
|
|
Awesome, thank you! |
maninga
added a commit
to maninga/parse-server
that referenced
this pull request
May 26, 2016
* upstream/master: (63 commits) Fixes parse-community#1649 (parse-community#1650) Update issue template (parse-community#1899) Break schemaController dependency. (parse-community#1901) Remove unnecessary null check Update schema mismatch error to include type string (parse-community#1898) Move more mongo specific stuff into mongo adapter Kill mongoOptions Consistent parameter order move transformWhere into mongo adapter Remove options from count Can't sort a count Remove limit from count Destructure mongo options remove adaptive collection call create + use adapter count instead of collection count transformWhere in MongoAdapter remove schemaController paramater Remove schemaController parameter Remove getRelationFields Remove all dependencies on schemaController ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really small change to the schema mismatch error message string.
Example schema:
Attempted bad request:
rocket.save({ launchTime: 'never!' })Error response before this pull request:
"schema mismatch for Rocket.launchTime; expected [object Object] but got String"Error response after this pull request:
"schema mismatch for Rocket.launchTime; expected Date but got String"