Add null check for relation type map.

[rozele]

For relations that are not explicitly defined in the schema, we need a null check here.

[codecov-io]

Current coverage is 92.07%

Merging #2114 into master will not change coverage

@@             master      #2114   diff @@
==========================================
  Files            93         93          
  Lines          6777       6777          
  Methods        1193       1193          
  Messages          0          0          
  Branches       1433       1433          
==========================================
  Hits           6240       6240          
  Misses          537        537          
  Partials          0          0          

Powered by Codecov. Last updated by 006540c...ef4b724

[ghost]

@rozele updated the pull request.

[ghost]

@rozele updated the pull request.

[rozele]

The build for this has failed twice non-deterministically for two different mongo versions. I don't think this change caused the failure.

[flovilmart]

Do you have a test/use case in particular that would be fixed by that PR? If so, please add it alongside the fix.

[rozele]

@flovilmart I don't have a particular test (I honestly don't know much about the parse-server), but if you look at line line 550 (https://github.com/ParsePlatform/parse-server/blob/master/src/Controllers/DatabaseController.js#L550), you'll see that a null check for expected type in the schema is not unprecedented. I found this issue while debugging a particular use case for the f8app (https://github.com/fbsamples/f8app). When you try to query for a relation that does not yet exist, an exception occurs.

[rozele]

Here's the specific line that creates an exception on the server:
https://github.com/fbsamples/f8app/blob/master/js/actions/schedule.js#L103

So when 'mySchedule' does not yet exist for a new user, this will throw.

[flovilmart]

There you have the test then! Can you please add it to the ParseQuery related tests?

[Shangyunliang]

it work!

[flovilmart]

I've added a test into #2319