Makes HTTPResponse serializable #2143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@flovilmart updated the pull request. |
1 similar comment
|
@flovilmart updated the pull request. |
|
@flovilmart updated the pull request. |
1 similar comment
|
@flovilmart updated the pull request. |
|
@flovilmart updated the pull request. |
|
Great job @flovilmart. |
|
@flovilmart updated the pull request. |
| let getText = () => { | ||
| if (!_text && this.buffer) { | ||
| _text = this.buffer.toString('utf-8'); | ||
| } else if (!_text && _data) { |
|
Looks great, i had two nits about whitespace but other than that shipit! |
flovilmart
changed the title
|
@flovilmart updated the pull request. |
1 similar comment
|
@flovilmart updated the pull request. |
|
Great job guys. Thank you for merging so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2033
response.body don't seem to be set in some cases, and was never specified in the node.js docs.
This change rely on the
bodyparameter from the response callback.Also, the getters have been replaced by ES5 definedProperty calls to make them enumerable so they play nice with serializers.
This change also does a bit of type inference in order to properly handle all body types (string, buffer and JSON)