Results invalid session when providing an invalid session token #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
LGTM |
|
let's wait for travis :P |
|
Absolutely! It looks like a good change though. |
|
Need to cleanup the error logging I just realized also |
|
@flovilmart updated the pull request. |
- The tests were failin when run in sequence as we called done() before the JSSDK had a chance to register the session token, therefore having a proper logout call in afterEach
|
@flovilmart updated the pull request. |
1 similar comment
|
@flovilmart updated the pull request. |
|
Stupid test failures... Found the root cause, |
|
@nlutsenko all good there after the test nits? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1605
Originally, an invalid session token would be let go as a 'nobody' auth, this PR enforces that when an invalid session token is passed, the response should be an error.